[PACK-1011] Support HH:MM:SS and MM:SS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardSoleCa
force-pushed
the
gs/pack-1011
branch
from
1381c51
to
f76defd
Compare
GerardSoleCa
force-pushed
the
gs/pack-1011
branch
from
f76defd
to
371dd14
Compare
essolsoj
approved these changes
Apr 13, 2021
ulyssedsn
approved these changes
Apr 13, 2021
jlopex
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for short time codes (MM:SS.mmmm)
This pull request includes a modification of the regex, and tests to validate the proper parsing.