Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample Weight not being applied correctly in binning_process when n_jobs != 1 #190

Closed
stroyal opened this issue Sep 6, 2022 · 1 comment
Closed

Sample Weight not being applied correctly in binning_process when n_jobs != 1 #190

stroyal opened this issue Sep 6, 2022 · 1 comment

Comments

@stroyal
Copy link

stroyal commented Sep 6, 2022 •
edited
Loading

Looks like you made the update to use sample_weight when n_jobs == 1 (as per #124) but not when n_jobs != 1:

Updates required in binning_process.py:
Lines 1151 & 1163
From:
self.special_codes, self.split_digits)

To:
self.special_codes, self.split_digits, sample_weight)
guillermo-navas-palencia added a commit that referenced this issue Sep 6, 2022
@guillermo-navas-palencia
Fix sample_weight for binning process when n_jobs > 1. See #190
ccae1fe
@guillermo-navas-palencia
Copy link
Owner

Thank you @stroyal

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stroyal @guillermo-navas-palencia