Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what is a folder name for Search in Files #241

Open
kgrossjo opened this issue Jul 24, 2017 · 4 comments
Open

Document what is a folder name for Search in Files #241

kgrossjo opened this issue Jul 24, 2017 · 4 comments

Comments

@kgrossjo
Copy link

The file search_and_replace_files.rst states:

Adding individual directories (Unix-style paths, even on Windows)

It doesn't talk about absolute versus relative paths, though. I believe if I have a project with just one folder C:/x in it, then entering foo/bar means C:/x/foo/bar. It should state this explicitly.

Also, what happens when I have more than one folder in my project?

And if I enter foo/bar, will it find all files under this folder hierarchy? E.g. will it find a file C:/x/foo/bar/a/b.c?

@FichteFoll
Copy link
Collaborator

It actually means /C/x/foo/bar, which may or may not be a bug internally. I agree that we should add an example for this for as long as this is the case, however.

@kgrossjo
Copy link
Author

I see the text has been changed. Thanks. However, what happens if the project contains more than one folder? That's not explained.

Also, it doesn't say whether it traverses the whole directory hierarchy or not.

Also, it could be clearer when explaining how they interact. It says we can "combine filters using commas", but it's not clear. The example shows three filters, let me construct two examples from this using two filters:

  • <current file>,<open folders>: Here, the comma must be a union operation, because otherwise it would be the same as <current file>, and thus it wouldn't make sense.
  • -*.txt,<open folders>: Here, the comma must be an intersection operation, because otherwise it would be the same as <open folders>, and thus it wouldn't make sense.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Aug 16, 2017

Yes, this section needs a revisit.

However, nobody changed anything on that page in a year, so your response kind of confuses me.

@kgrossjo
Copy link
Author

It has this sentence: "Relative paths in filters are interpreted to start at the root of the active project." How could I have missed it before? :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants