Guillotina 5 support #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodbare
requested changes
Jun 22, 2019
| @@ -1,17 +1,21 @@ | |||
| import os | |||
|
|
|||
| from guillotina import configure | |||
| from guillotina.component import get_utility | |||
| from guillotina.contrib.catalog.pg import sqlq | |||
There was a problem hiding this comment.
We should not import contrib packages on modules, no ?
There was a problem hiding this comment.
Let me do some tests. Maybe we just need to make sure in guillotina this is okay and doesn't auto import it.
The the use-case of linkintegrity, pg catalog will always be enabled.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
+ Coverage 87.22% 89.9% +2.67%
=========================================
Files 11 11
Lines 548 505 -43
=========================================
- Hits 478 454 -24
+ Misses 70 51 -19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.