Add support for RabbitMQ #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseImage.get_port() can be called with a 'port' argument (for the rabbitmq container, because it opens multiple tcp services, get_port() would fail because it would return the first container port in the list). This fixes this problem and allows to get a container's listening port for a port different than the 'main' service (i hope that was clear ^^)
vangheem
approved these changes
Nov 13, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for RabbitMQ
The connection check is done with pika.
BaseImage.get_port() can be called with a 'port' argument
(for the rabbitmq container, because it opens multiple tcp
services, get_port() would fail because it would return the
first container port in the list). This fixes this problem
and allows to get a container's listening port for a port
different than the 'main' service (i hope that was clear ^^)