Fixed Tuple Index Out of range error and unit test.

guitarmind · Dec 27, 2018 · f68cfcd · f68cfcd
1 parent 0fad976
commit f68cfcd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/boruta/boruta_py.py b/boruta/boruta_py.py
@@ -333,7 +333,7 @@ def _fit(self, X, y):
         imp_history_rejected = imp_history[1:, not_selected] * -1
 
         # update rank for not_selected features
-        if not_selected.shape[0] > 0 and not_selected.shape[1] > 0:
+        if not_selected.shape[0] > 0:
                 # calculate ranks in each iteration, then median of ranks across feats
                 iter_ranks = self._nanrankdata(imp_history_rejected, axis=1)
                 rank_medians = np.nanmedian(iter_ranks, axis=0)

diff --git a/boruta/test/unit_tests.py b/boruta/test/unit_tests.py
@@ -40,7 +40,7 @@ def test_if_boruta_extracts_relevant_features(self):
         bt.fit(X, y)
 
         # make sure that only all the relevant features are returned
-        self.assertItemsEqual(range(5), list(np.where(bt.support_)[0]))
+        self.assertListEqual(list(range(5)), list(np.where(bt.support_)[0]))
 
 
 if __name__ == '__main__':