-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
still AltGr / ISO-L3 key problems #149
Comments
Thank you for the very detailed report @macdanger . This is really helpful. Before going further, lets see if using raw key events fixes this:
|
thanks for your quick response.
The RawKeyboard parameter togther with the debug version of avnc did not change much, at least it is still not working. But I can see a difference in regard to the transmitted keycodes:
Overall with RawKeyboard it looks that there is a bigger missmatch between the Book Cover Keyboard layout and the xkb layout on the server: e.g. now I cannot use the curser keys and some other keys. EDIT: I just like to add: it does not depend on the Samsung Book Cover keyboard, using the exact same hardware keyboard from my desktop via bluetooth with avnc, avnc generates different keycodes then e.g. tigervncclient. The right-alt (AltGr) key ends up as keycode 108 with tigervncclient but is 142 with avnc using the same hardware keyboard. |
Please try this APK (with
Raw key events bypasses this setting.
Yeah, previous APK was not encoding raw key events correctly. I assumed scancodes received from Android were XT scancodes, but actually they are Linux kernel keycodes. Q: Can you compile TigerVNC from source (or somehow use newer version)? |
Now this new debug version works perfectly! Even the super and cursor keys work correctly!
you mean update the server binary? I'm using the Debian standard package, which is currently on version:
|
Yes. I was testing TigerVNC 1.13 and it has improved key handling, even without raw key events.
That's why I was wondering if you could compile from source. In any case, raw key events in AVNC still need a bit more polishing, and I will close this issue when it's ready. |
v2.2.0 is now available with raw key event support. |
Hi, sorry to jump in here again, but it looks that the newer versions have a slightly different implementation of the raw keys. When using the 2.1.2 (debug) version from this thread, all is perfectly fine. When I use the news version, alt least the super keys don't work. Everything else seems to be the same. Shoult I open a new issue? |
No problem, I will take a closer look later today. Which specific version is not working correctly: v2.2.0 or v2.2.1 No need to open new issue, I will just reopen this one. |
2.2.1 seems not to work with super keys |
After a bit of testing, it looks like Super should work correctly. My device intercepts Super key for Google app so I can't test it directly. But if map any other key to Super, it works as expected. Please run the Key test in AVNC settings for Super keys, and paste event logs here. |
Oh man, sorry, it looks like you are right. now after cleaning up and comparing my config from the 2.1.2 (debug) with the 2.2.1 release - it just works as expected. Strange. Sorry, I hope I didn't cause too much trouble for you checking :-) |
No problem, this sort of thing has happened more than once to me too when testing AVNC with different configurations. I did find a test which was not running, so that's a net positive. |
Hi, first of all thanks for providing one of the best VNC clients on Android IMHO!
Problem: unable to type L3 characters (using the AltGr modifier) against tigervncserver on Debian while tigervncclient works well
Test cases:
For generating logs I used:
It looks like avnc is sending confusing / incorrect keypress / keyrelease events when using AltGr. When using avnc'S right-alt-to-super mapping it works e.g. in gnome terminal but not in Firefox or Thunderbird. It is especially painfull in Thunderbird as the '@' (at) is actually AltGr+Q on a German keyboard.
The correct sequence (sent by tigervncclient and other working clients):
key-test_BACKSLASH_no-super-mapping_not-working_avnc.txt
key-test_BACKSLASH_right-alt-to-super-mapping_half-working_avnc.txt
xev_events_BACKSLASH_no-super-mapping_not-working_avnc.txt
xev_events_BACKSLASH_right-alt-to-super-mapping_half-working_avnc.txt
xev_events_BACKSLASH_working_tigervncviewer.txt
xinput_events_BACKSLASH_no-super-mapping_not-working_avnc.txt
xinput_events_BACKSLASH_right-alt-to-super-mapping_half-working_avnc.txt
xinput_events_BACKSLASH_working_tigervncviewer.txt
The text was updated successfully, but these errors were encountered: