Strange bug with bare option

[jescalan]

This is super weird, and I'm not totally sure it's gulp-coffee's fault, but hear me out on this one.

Gulp task, compiles coffeescript. I add in the { bare: true } option, assuming all will go well since I'm compiling node anyway. When they come out, the coffeescript extension __extends is not getting compiled at the top of files that use classes (this is breaking and causes all files with classes to immediately throw an error).

Get rid of the bare option and it's back, albeit with an extra useless function wrapper now. Looks like a bug in coffeescript to me, really. Make sure locally installed coffeescript is the same version as the one required by gulp-coffee (1.6.3, yep, but you guys should be using 1.x.x in your package.json, because semver), compile the file manually with the bare option. __extends is defined in the files, and no function wrapper, everything works perfectly. Wat?

So I checked the source and it looks like you guys are just compiling through coffee-script, as usual, but I figured I'd at least log this here because compiling with coffee manually didn't break anything, but the compilation through gulp caused breakage.

Any thoughts or help on this appreciated!

[yocontra]

Interesting. Will look at this when I have a minute.

[leny]

Additionally, when you use { bare: true }, the coffee-script compiler doesn't declare top-scope variables anymore... and strips all the empty lines.

[leny]

After some tests, the bug seems happening when giving multiple files by glob.

gulp.src( [ "src/**/*.litcoffee" ] )
        .pipe( coffee( options ) )
            .on( "error", gutil.log )
        .pipe gulp.dest "bin"

-> generates bugs and undeclared variables

gulp.src( [ "src/models/dicecheck.litcoffee" ] )
        .pipe( coffee( options ) )
            .on( "error", gutil.log )
        .pipe gulp.dest "bin"

-> generate proper compiled file

---

I have absolutely no idea how to debug this (I still haven't much experience with gulp), but this is really anoying... :(

[leny]

I've found it !

When you send multiple files, the optionsseems to be populated with properties which confuse the coffeescript compiler.

I will make a pull request this afternoon.

[yocontra]

Which options?

Also, does the litcoffee stuff work fine without telling the coffee compiler specifically that it is litcoffee?

[yocontra]

Hmm maybe we should infer that from the file extension instead of explicity passing in literate: true - thoughts?

[leny]

When you don't give literate: true, compilation fails on some files :/

[dashed]

I can confirm this bug for config { bare: true }.

Using the class example in http://coffeescript.org/#classes

The compiled js gets borked: https://github.com/Dashed/gulp-coffee-sandbox/blob/master/src/subdir/a.js

The global vars seems to be missing.

[leny]

I'm currently writing a fix, I will make the pull request soon.

[leny]

Et voilà ! 290f1fc

[dashed]

Fantastic, I just tested your PR on my sandbox. Works perfectly.

[leny]

You're welcome.

I hope it will be merged & published on npm soon, to fix the issues in my work-project builds... :)

[dashed]

@leny You may want to add more default options into your PR as listed here: https://github.com/gruntjs/grunt-contrib-coffee/blob/master/tasks/coffee.js#L17

[leny]

@dashed done. Thanks.

[jescalan]

👍 great work guys!

[dashed]

@Jenius it's patched in 1.2.5 and is available on npm. =] if it works as your side, and there are no outstanding problems, then please close this ticket

[jescalan]

Looks good - thanks guys!