Corrupts binary files (non-unicode files)

[simplesmiler]

var gulp = require('gulp');
var zip = require('gulp-zip');
var concat = require('gulp-concat');

gulp.task('default', function() {
  return gulp.src('gulpfile.js')
    .pipe(zip('gulpfile.zip'))
    .pipe(concat('gulpfile.zip'))
    .pipe(gulp.dest('.'));
});

Resulting gulpfile.zip is corrupted. With concat line commented out everything works as expected.

gulp-concat v2.4.2, gulp v3.8.10, node v0.10.31

[simplesmiler]

To be more specific, corrupts non-unicode files.
Introduced in 2.3.0 with adding support for sourcemaps.

[yocontra]

cc @floridoo

I'm pretty sure I talked about this when the sourcemaps stuff was first proposed - I wanted to make sure that it didn't break binary files

[floridoo]

@contra this is not a problem with concat-with-sourcemaps, the problem is that

file.contents !== new Buffer(file.contents.toString())

for binary files.

[yocontra]

@floridoo does concat-with-sourcemaps take in a buffer as an argument? The problem is right here where we convert to a string before passing it https://github.com/wearefractal/gulp-concat/blob/master/index.js#L35

[floridoo]

@contra currently not, but I can look int adding that feature.
BTW: what would be a use case for cancatenating binary files?

[yocontra]

@floridoo I can't think of any in my day to day but it isn't just binary, it could be any file in another encoding that isn't utf8. I 100% think we should support this. I think concat-with-sourcemaps just needs to use Buffer and Buffer.concat instead of strings and +=

[yocontra]

@floridoo If a file has no sourceMap then it should basically revert to the pre-sourcemaps behavior

[simplesmiler]

Use cases I'm aware of are node-webkit and love2d. They use concatenation of binary interpreter with zipped application source to ease distribution on certain platforms.

[martinib77]

Hi i'm using node-webkit and i'm having this issue. Is there any solution? Thanks.

[simplesmiler]

@martinib77, my current workaround is to stick with 2.2.0.

[yocontra]

Put "concat":"2.2.0" in your package.json dependencies list for a workaround. This will be fixed soon.

@floridoo Alive?

[martinib77]

That worked, thanks!

[floridoo]

@contra I'm fine, just very busy ;)

[yocontra]

Published as 2.4.3

[simplesmiler]

👍