Replace Tap with Mocha as the test framework #201
Conversation
| pipe( | ||
| [gulp.src(filename), task()], | ||
| (err) => { | ||
| try { |
There was a problem hiding this comment.
Thrown errors here don't bubble up to the test?
There was a problem hiding this comment.
This is related to not using miss.concat in this test: I was just checking for the existence of an error and did not care about the content.
There was a problem hiding this comment.
I have to keep this style to pass the error to done.
| .pipe(task()) | ||
| .pipe(expectStream(t)); | ||
| }); | ||
| return through.obj(assert); |
There was a problem hiding this comment.
This actually needs to be concat if we plan to keep this abstraction.
There was a problem hiding this comment.
My understanding is that this function acts as a stream transformation (pass-through or error). Draining should be handled outside of it. I added concat calls to the pipes using it.
demurgos
force-pushed
the
test-framework
branch
2 times, most recently
from
668d789
to
e13decf
Compare
The tests should remain equivalent. Closes gulp-community#196
|
I fixed the small issues. I'm looking into getting rid of the |
|
@phated I update the tests to no longer depend on |
The tests should remain equivalent.
Closes #196