Fix 317 #323
Merged
Fix 317 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into Travis |
|
@nmccready It's C stuff. Is there no way to test the memory leaks without it? |
|
@phated I think I know the problem. I already did this update for travis in the debug-fabulous project. Anyway travis made things more complicated and we need to tell it to explicitly install C libs for node. |
|
See travis.yml |
|
Ill fix it. |
|
Now looks like npm is failing to run or install on node 0.12 and 0.10. |
|
Don't install npm@latest... it no longer works on 0.10 - Either lock it at 4 or use the version it ships with. |
|
ugghhh.... I will keep digging or remove the memwatch-next stuff. |
nmccready
force-pushed
the
nmccready/loggingMemleak
branch
from
0923ca5
to
da4cdb2
Compare
|
@phated finally fixed.. gave up on memwatch-next and all that. |
|
@nmccready not much for me to review now 😛 looks good to ship! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leak fixes and tests.