-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same sourceFile Name when applySourceMap #8
Conversation
I still have other issue... |
As mentioned in the original comment this seems to fix the gulp-sass|gulp-autoprefixer|gulp-sourcemaps issue. Why has this not been merged? Does it create other issues? |
Not as far as I know... |
What did you refer to when you said you had an other issue @clempat? Did this create some issue or did it not fix your issue after all? |
Ah Yes true, shame I don't remember why I said I still had an issue. What I can say now is I was using it on project using gulp and did not get anymore issues as far I remember. And for sure was fixing the issues I mentioned. |
Sorry for the late answer. This was not merged because this change seems wrong to me: The second parameter to Can you explain to me why it should be |
I would have to check again as it was some time ago. As well that I start now to use npm script. Yeah got into the way grunt->gulp->npm script :)... I could just refer to my comment:
https://github.com/mozilla/source-map/blob/0.4.4/lib/source-map/source-map-generator.js#L194 |
Thanks @clempat! |
BTW, this is the cause of this issue too: terinjokes/gulp-uglify#105 |
I maybe miss something but this Fix would be related to:
Can you tell me what do you think ?