Bugfix for the issue #2

gulpjs · Sep 19, 2016 · 1457f7a · 1457f7a
1 parent 4e6cbea
commit 1457f7a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/lib/foreach-props.js b/lib/foreach-props.js
@@ -23,6 +23,6 @@ function foreachNode(node, basekey, fn) {
       continue;
     }
 
-    node[key] = fn(val, keychain.slice(1));
+    fn(val, keychain.slice(1));
   }
 }
diff --git a/package.json b/package.json
@@ -39,6 +39,7 @@
     "testrun": "^0.7.0"
   },
   "dependencies": {
+    "lodash.assign": "^4.2.0",
     "lodash.isplainobject": "^4.0.6",
     "lodash.set": "^4.3.2"
   }

diff --git a/test/copy-props.js b/test/copy-props.js
@@ -2,10 +2,13 @@
 
 var assert = require('assert');
 var testrun = require('testrun').mocha;
+var assign = require('lodash.assign');
 var copyProps = require('../');
 
 function testfn(testcase) {
+  var src = assign({}, testcase.src);
   var ret = copyProps(testcase.src, testcase.dst, testcase.map, testcase.fn);
+  assert.deepEqual(src, testcase.src);
   assert.strictEqual(ret, testcase.dst);
   return ret;
 }

diff --git a/test/foreach-props.js b/test/foreach-props.js
@@ -1,13 +1,17 @@
 'use strict';
 
 var testrun = require('testrun').mocha;
+var assert = require('assert');
 var foreachProps = require('../lib/foreach-props');
+var assign = require('lodash.assign');
 
 function testfn(testcase) {
   var logs = [];
+  var src = assign({}, testcase.obj);
   foreachProps(testcase.obj, function(value, keychain) {
     logs.push({ keychain: keychain, value: value });
   });
+  assert.deepEqual(testcase.obj, src);
   return logs;
 }