Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dateformat with time-stamp #3

Merged
merged 2 commits into from
Feb 9, 2016
Merged

Conversation

jonschlinkert
Copy link
Contributor

related to #2

@jonschlinkert
Copy link
Contributor Author

@phated you ok with merging this?

@jonschlinkert
Copy link
Contributor Author

@phated ping, sorry to be a pest. the dateformat lib includes meow as a dep, which adds 48 dependencies (that aren't used) every time this lib is installed.

I don't mind doing the work on this, just wanted to make sure you're good with it first. if not, that's ok, we can work around it.

@phated
Copy link
Member

phated commented Feb 9, 2016

Sorry about that. I should be able to get to this tomorrow. Is there a reason you haven't bumped time-stamp to 1.0.0? I'd prefer deps to be major bumped whenever we have control of it.

@jonschlinkert
Copy link
Contributor Author

Sorry about that.

no worries at all, I didn't lose any sleep over it. I just have a tendency to forget and happened to think about it

Is there a reason you haven't bumped time-stamp to 1.0.0? I'd prefer deps to be major bumped whenever we have control of it.

no prob, I can bump to 1.0

@phated
Copy link
Member

phated commented Feb 9, 2016

Thanks @jonschlinkert - just wondering why you used mm instead of MM; isn't the capitalized version part of some standard formatting syntax?

phated added a commit that referenced this pull request Feb 9, 2016
replace dateformat with time-stamp
@phated phated merged commit beea408 into gulpjs:master Feb 9, 2016
@phated
Copy link
Member

phated commented Feb 9, 2016

Published as 1.2.0 (wasn't sure if it felt like a minor or patch).

@jonschlinkert
Copy link
Contributor Author

thanks!

@jonschlinkert
Copy link
Contributor Author

just wondering why you used mm instead of MM; isn't the capitalized version part of some standard formatting syntax?

sorry just noticed this. I think MM usually signifies month and mm signifies minute, but I'm sure it depends on the lib. not sure if there is a spec for that or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants