Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update behavior for non-glob path strings #4

Merged
merged 3 commits into from
Sep 18, 2015
Merged

Update behavior for non-glob path strings #4

merged 3 commits into from
Sep 18, 2015

Conversation

es128
Copy link
Contributor

@es128 es128 commented Sep 9, 2015

The discussion isn't necessarily settled yet, but just getting the PR started. When landed, should resolve #3.

As of now, this PR would provide parity with glob2base's treatment of regular (non-glob) paths.

/cc @jonschlinkert @robwierzbowski @contra @phated

@phated
Copy link
Member

phated commented Sep 9, 2015

👍 on parity, I just skimmed the discussion

es128 added a commit that referenced this pull request Sep 18, 2015
Update behavior for non-glob path strings
@es128 es128 merged commit f324204 into master Sep 18, 2015
@es128 es128 deleted the non-glob-parent branch September 18, 2015 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't return the correct base from non-globby strings
2 participants