feat!: Replace glob anymatch & custom directory walk #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress to replace our usage of
glob
withwalkdir
+anymatch
. I'll be swapping out the walkdir for a custom fork and I'm still fixing bugs into-absolute-glob
.The general idea here is to make
glob-stream
globbing work as close tochokidar
as we possibly can. Using multiple globbing libraries has produced way too many edge cases between our various APIs (I think I counted 6 opened currently).As of PR #115, we no longer support ordered globs. We were probably the only tool that has done this and it just adds to our headaches. If users want ordered globs, they can use
ordered-read-streams
to combinegulp.src
calls. This means that we'll only be generating a single stream from glob-stream (and thus only do 1 filesystem walk).closes #111