Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Switch to streamx #119

Merged
merged 7 commits into from
Apr 23, 2023
Merged

feat!: Switch to streamx #119

merged 7 commits into from
Apr 23, 2023

Conversation

phated
Copy link
Member

@phated phated commented Jan 4, 2023 •
edited

This migrates the project to streamx and tests with a variety of stream modules.

Closes #110
Closes #112

@phated
feat!: Switch to streamx
f60f138 
chore: Ensure project works with different streams
@phated
Copy link
Member Author

phated commented Jan 4, 2023

@sttk please verify that your problem from #112 was fixed. I believe it was fixed when I dropped node-glob, but tests were added in this PR.

@phated phated added this to In progress in v5 Jan 4, 2023
sttk
sttk suggested changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated I've reviewed and verified this code by the first sample code in #112 and vinyl-fs tests. Backpressure implementation works well, but two test cases in vinyl-fs failed about relative cwd.

I've pointed out it and one more point about a option. Please fix them.

index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
sttk
sttk approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR again, and your work is great! I've approved this.

@phated phated merged commit 8d6b35c into master Apr 23, 2023
15 checks passed
@phated phated deleted the phated/streamx branch April 23, 2023 20:51
@github-actions github-actions bot mentioned this pull request Apr 23, 2023
Merged
@phated phated moved this from In progress to Done in v5 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttk sttk sttk approved these changes

@yocontra yocontra Awaiting requested review from yocontra

@coreyfarrell coreyfarrell Awaiting requested review from coreyfarrell

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lists only 16 or less files when a glob string including no globstar. Switch to streamx
2 participants
@phated @sttk