-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Minimatch class to improve perf, fixes #29; fix RegExp handling #30
Conversation
@contra BTW, there is just one line missing to hit 100% coverage. Perhaps we should throw instead of returning true for unknown glob types? https://coveralls.io/files/408135441#L105 |
Here are the benchmarks to prove the perf gain. Benchmark source: sindresorhus/globby#10 (irrelevant globby data omitted) |
I may have misunderstood the regex matching part though, it would make more sense if the |
e7af5f8
to
e2f5e34
Compare
@contra PTAL when you have time. |
Nice! |
Oh sorry, mixing too many topics here. Moved the glob-stream and globby topic to #31 |
The RegExp stuff should keep the file if the regex returns true, otherwise filter it out as implemented. Want to write some tests to ensure this is happening? |
@contra I did, see the files changed tab. 😃 |
use Minimatch class to improve perf, fixes #29; fix RegExp handling
use Minimatch class to improve perf, fixes #29; fix RegExp handling
use Minimatch class to improve perf, fixes #29; fix RegExp handling
Improve negative globs handling perf and fix some issues with RegExp.