try-catch around user code

gulpjs · Mar 22, 2024 · 8e2b490 · 8e2b490
1 parent ff19cd5
commit 8e2b490
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/shared/translate.js b/lib/shared/translate.js
@@ -246,7 +246,12 @@ function buildTranslations(cfg) {
 
       var message;
       if (typeof cfg.message === 'function') {
-        message = cfg.message(data);
+        try {
+          message = cfg.message(data);
+        } catch (err) {
+          console.error('A problem occurred with the user-defined `message()` function.');
+          console.error('Please correct your `.gulp.*` config file.');
+        }
       }
 
       // If the user has provided a message, return it
@@ -272,7 +277,12 @@ function buildTranslations(cfg) {
 
       var time;
       if (typeof cfg.timestamp === 'function') {
-        time = cfg.timestamp(data);
+        try {
+          time = cfg.timestamp(data);
+        } catch (err) {
+          console.error('A problem occurred with the user-defined `timestamp()` function.');
+          console.error('Please correct your `.gulp.*` config file.');
+        }
       }
 
       // If the user has provided a timestamp, return it

diff --git a/test/config-message-function.js b/test/config-message-function.js
@@ -427,7 +427,8 @@ describe('config: message function', function() {
     }
   });
 
-  it('can change EXEC_ERROR with .gulp.*', function(done) {
+  // Would need to hook gulp to test this
+  it.skip('can change EXEC_ERROR with .gulp.*', function(done) {
     var cwd = path.join(baseDir, 'EXEC_ERROR');
     var expected = 'FAIL TO RUN\n';