Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return exit code 1 when incomplete tasks are detected on gulp v3 #149

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Jan 20, 2018

I've implement for gulp v3 to return exit code 1 and print warning messages when there are incomlete tasks. (Related: #145 and gulpjs/gulp#2081.)

@phated
Copy link
Member

phated commented Jan 20, 2018

I don't believe we can successfully detect incomplete tasks because gulp 3 supported sync tasks. So everything "completed"

@sttk
Copy link
Contributor Author

sttk commented Jan 21, 2018

@phated gulp receives the events of starting and finishing a task, and outputs these logs. So incomplete tasks can detect by finding tasks which started but not finished at the end of gulp.
This pr implements this process simply. This works well about sync tasks, too.

BTW, I'm sorry but I found a bug in this pr. If a task error occured, this pr outputs incomplete tasks warning though gulp4 does not output.

@sttk
Copy link
Contributor Author

sttk commented Jan 21, 2018

@phated I wrote the wrong thing. As you wrote, gulp v3 cannot detect incomplete task which is a sync task but execute async process in it. Umm... Should we cancel this pr?

@phated
Copy link
Member

phated commented Jan 22, 2018

@sttk yeah, you found what I was talking about. I'll close this as it doesn't make sense for 3.x

@phated phated closed this Jan 22, 2018
@sttk sttk deleted the return-exit-code-1-when-tasks-are-incomplete-on-gulp3 branch January 22, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants