Allow options to override error #41
Conversation
If an error was missing certain fields, they couldn't be provided by the opt parameter. This resolves that. It also checks showStack for actually being true, 'undefined' was filtering through.
|
Yay much cleaner - love it. Can you provide a simple test or two for the behavior? |
|
@RR2DO2 ping :) |
|
This completely slipped my mind - added a quick test. |
|
FYI I'm working on a rewrite of this as its own module |
Allow options to override error
|
Published as 2.2.17 |
|
Pull request #53 may be an even better solution for this, because I was running into the same problem when I started work on a mtscout6/gulp-cjsx plugin. Since the fileName property that comes from CoffeeScript syntax errors is 'filename' not 'fileName'. Case sensitivity bites sometimes. |
|
@mtscout6 PR to take either filename or fileName off the error would work |
|
My main concern is that there it's entirely possible to other properties as well. I'd hate to keep whitelisting different possibilities for all the different libraries that may or will exist. Hence my reasoning for #53 which will bring over all the properties from any error passed in, but giving you the option to reduce to a finite white list if you feel the need to. |
|
#53 makes sense |
If an error was missing certain fields, they couldn't be provided by the opt parameter. This resolves that. It also checks showStack for actually being true, 'undefined' was filtering through.