Permalink
Browse files

Breaking: Update dependencies & increase alpha version

  • Loading branch information...
phated committed Dec 21, 2017
1 parent 6d71a65 commit 99bdc9ead25ff02dd2309991eea3ebdb60ab8080
Showing with 4 additions and 4 deletions.
  1. +4 −4 package.json
View
@@ -1,7 +1,7 @@
{
"name": "gulp",
"description": "The streaming build system",
"version": "4.0.0-alpha.2",
"version": "4.0.0-alpha.3",
"homepage": "http://gulpjs.com",
"repository": "gulpjs/gulp",
"author": "Fractal <contact@wearefractal.com> (http://wearefractal.com/)",
@@ -23,10 +23,10 @@
},
"man": "gulp.1",
"dependencies": {
"glob-watcher": "^3.0.0",
"gulp-cli": "^1.0.0",
"glob-watcher": "^4.0.0",
"gulp-cli": "^2.0.0",
"undertaker": "^1.0.0",
"vinyl-fs": "^2.0.0"
"vinyl-fs": "^3.0.0"
},
"devDependencies": {
"coveralls": "^2.7.0",

3 comments on commit 99bdc9e

@phated

This comment has been minimized.

Show comment
Hide comment
@phated

phated Dec 21, 2017

Member

@MylesBorins it looks like node 9 breaks us here. Any idea why? Failed node 9 build: https://travis-ci.org/gulpjs/gulp/jobs/319961359

Member

phated replied Dec 21, 2017

@MylesBorins it looks like node 9 breaks us here. Any idea why? Failed node 9 build: https://travis-ci.org/gulpjs/gulp/jobs/319961359

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jan 17, 2018

Error that I'm seeing on our end is

From line 72 in the test dest.js

var outstream = instream.pipe(gulp.dest(outpath));
  1) gulp.dest() should return a output stream that writes streaming files into new directories:
     Uncaught TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type Function
      at WriteStream.close (fs.js:2298:10)
      at finishMaybe (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at afterWrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:470:3)
      at onwrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:461:7)
      at WritableState.onwrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:169:5)
      at onFutimes (node_modules/vinyl-fs/lib/file-operations.js:264:9)
      at FSReqWrap.oncomplete (fs.js:149:20)

edit: fwiw this fails all the way bay to 9.0... so it was a semver major change to stream that is causing this most likely. I'm going to dig into vinylfs

MylesBorins replied Jan 17, 2018

Error that I'm seeing on our end is

From line 72 in the test dest.js

var outstream = instream.pipe(gulp.dest(outpath));
  1) gulp.dest() should return a output stream that writes streaming files into new directories:
     Uncaught TypeError [ERR_INVALID_ARG_TYPE]: The "listener" argument must be of type Function
      at WriteStream.close (fs.js:2298:10)
      at finishMaybe (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:607:14)
      at afterWrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:470:3)
      at onwrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:461:7)
      at WritableState.onwrite (node_modules/flush-write-stream/node_modules/readable-stream/lib/_stream_writable.js:169:5)
      at onFutimes (node_modules/vinyl-fs/lib/file-operations.js:264:9)
      at FSReqWrap.oncomplete (fs.js:149:20)

edit: fwiw this fails all the way bay to 9.0... so it was a semver major change to stream that is causing this most likely. I'm going to dig into vinylfs

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina replied Jan 17, 2018

Proposed Fix: gulpjs/vinyl-fs#296

Please sign in to comment.