Implement new logger in CLI

[phated]

New logger available at https://github.com/gulpjs/gulplog

A bunch of issues opened at https://github.com/gulpjs/gulplog/issues

[kahlil]

@phated anybody on this yet? I'd be happy to help this along otherwise.

[phated]

not any more than the initial commit on gulplog. The best place to start would be to bring gulplog into the CLI (4.0 branch) and wire up the event listeners. Once everything gets hooked up for that, we can implement it as branching logic in gulp-util

[phated]

@kahlil are you tackling this?

[kahlil]

Hey there! Sorry for the silence. I will see if I can fit it in next week. Will let you know if it worked or not :)

Von meinem iPhone gesendet

Am 03.09.2015 um 20:20 schrieb Blaine Bublitz notifications@github.com:

@kahlil are you tackling this?

—
Reply to this email directly or view it on GitHub.

[kahlil]

@phated

OK, just so I understand correctly, you need me to:

• check out gulp-cli 4.0 branch
• add gulplog as a dependency there
• use gulplog in gulp-cli everywhere instead of gutil.log
• remove gulp-util completely
• let you know that its done so it can be "implemented as branching logic" (I have no idea what that means, can you explain that please?)

[yocontra]

@kahlil Also completely removing gulp-util which should be unused after getting of gutil.log

[kahlil]

@contra got it. will get on it as soon as i can.

[kahlil]

@contra + @phated since your instructions are pretty minimal I'd like to make sure I am doing it right so here is how I would do it:

• require gulplog
• use gulplog like this: https://github.com/kahlil/gulp-cli/blob/4.0-introduce-gulplog/index.js#L71-L73
• extract gulp.util functionality like this: https://github.com/kahlil/gulp-cli/blob/4.0-introduce-gulplog/lib/shared/log/toConsole.js
• require that functionality like this: https://github.com/kahlil/gulp-cli/blob/4.0-introduce-gulplog/index.js#L21
• and wire up the listeners like this: https://github.com/kahlil/gulp-cli/blob/4.0-introduce-gulplog/index.js#L31

Is that approx. what you have in mind? Not sure if I am completely off course or not

[phated]

@kahlil yeah, this stuff is looking really good. Also, this weekend I pulled the gulp-util logging out into a module (fancy-log) that can be used instead of embedding the logic.

[phated]

One other thing to mention is that the CLI needs a way to suppress different levels so a log level parameter or config object should be passed into toConsole I think.

[kahlil]

@phated sounds good! How do you want users to specify the log levels on the cli? Via a number: --log-level 2 or rather via the keywords error, warn, info, debug: --log-level warn? Or in a different way?

[phated]

@kahlil I was thinking about copying npm for log levels, e.g. -vvv for the most verbose. The newest version of yargs has support for counting a flag (not sure if old versions do). Thoughts? /cc @contra

[phated]

Many thanks to @kahlil! As of gulpjs/gulp-cli#32, gulp-cli 4.0 branch no longer has a dependency on gulp-util and has a real logger!

[kahlil]

\o/