-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate gulp-util #360
Comments
Questions:
|
|
Any progress on this? |
@ilanbiala Have to finish BetterError everything else is already moved out |
color -> chalk |
combine -> https://www.npmjs.com/package/multipipe Others: |
@phated No I think we set the standard already with templating, we can put in the plugin docs to use lodash.template and that changing the settings is blacklistable |
Why not use an existing logging library? There's already a million of them, no need to make a new one. I like the look of logdown, especially the prefix stuff. |
@callumacrae we need to support differing versions of the logger without forcing plugins to update. This is supported in glogg through a global instance. |
✋ I can update and maintain BetterError module since I know a lot about the PluginError. |
I don't know what kind of minor changes the plugin-error module includes, but I, and probably a lot of gulp users, want to use just a simple port of gutil.PluginError. |
@shinnn I wanted to make some API changes in BetterError (dropping support for all of the crazy argument overrides) to simplify it. Would love help maintaining it if you're interested! I'd say use plugin-error if you want a straight port |
OK, first just copy the PluginError code and paste it to the BetterError. Then, let's discuss API change. I prefer simplicity, too. |
@shinnn if "you know a lot about the PluginError" you can see it, i cant currently. Code is simliar, readme is good enough for me. Other than code style and better formatting, and use of smaller and faster modules, i cant see. Just check it out, before start something. or @jonschlinkert to come and describe what's the exact differences. |
My goal was just to use PluginError as a standalone module without having to require gulp-util and the other deps that I don't always need. I'd be more than happy to transfer the repo to gulp (without strings of requiring me to be a maintainer or whatever). Or I'm completely fine with re-starting the whatever works for you guys. just let me know what I can do to help. |
I thought @jonschlinkert's plugin-error module does slightly different things from gutil.PluginError, judging from a phrase in the readme, "with minor changes". However, if they actually do the same thing, now I think #360 (comment) is also a good plan. |
I'm pretty sure that was my goal, fwiw I put this in the actual github project |
Anyway I submitted a PR to the BetterError repository. yocontra/BetterError#1 Now I totally agree to @contra's comment #360 (comment):
BetterError and plugin-error seem to be going towards the different goals and it's worth maintaining them separately. |
perfect! makes much more sense
there's no need for plugin-error now. I'll just deprecate it and use |
@jonschlinkert BetterError has totally different goals, if you want a stand-in for PluginError then BetterError isn't it because the API signature and behavior will be totally different. |
good to know, I'll take some time and look over the code. Either way I'd rather try to make changes in our libs to support BetterError if that's the goal for gulp. I have no interest in supporting any API differences unless I have to for backward compatibility or whatever. thanks |
@jonschlinkert The idea is that existing things can stay on PluginError if they want to, nobody is removing gulp-util from the registry or anything - we just aren't working on it anymore and telling people not to use it. New stuff will use BetterError, and any developers who give a shit about their plugins will switch over after the deprecation is issued |
Do we have an official/recommended alternative to log yet? |
@RehanSaeed See this issue #1208 |
Is this still a thing? Is https://github.com/gulpjs/gulp-util still planned to be deprecated? If yes, would it make sense to mention it in the README of the gulp-util project? |
@Meligy this is definitely happening. We will be publishing a version that has deprecation warnings with alternative library suggestions and then labeling this repo as deprecated |
@contra Any progress with BetterError? There are many small plugins which load large gulp-util stuff (much bigger now) only for PluginError. |
@TrySound No progress, if anybody else has time to take a whack at it that would be much appreciated |
@contra We can't contribute to BetterError project at least if you show us its desired API as you said in yocontra/BetterError#1 (comment). |
@shinnn There is no project and no desired API - feel free to build anything you want that solves the problem of error display + error prefixing w/ plugin names and do it however you want |
Couldn't |
gulp-util has been deprecated now - see https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5 for more information. |
Related: https://github.com/gulpjs/gulp-util/tree/descope
The text was updated successfully, but these errors were encountered: