Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch method to proxy to chokidar #1247

Closed
phated opened this issue Sep 10, 2015 · 4 comments
Closed

Watch method to proxy to chokidar #1247

phated opened this issue Sep 10, 2015 · 4 comments

Comments

@phated
Copy link
Member

phated commented Sep 10, 2015

We need to update the watch method for gulp 4 to just use chokidar directly since vinyl-fs is removing the watch syntax in 2.0 (as per gulpjs/vinyl-fs#92)

I know @es128 has mentioned he be able to help with this task.

@phated phated added this to the gulp 4 milestone Sep 10, 2015
@es128
Copy link
Contributor

es128 commented Sep 10, 2015

Yup I owe you a PR for this

@ddprrt
Copy link
Contributor

ddprrt commented Sep 15, 2015

I had a look into it. How should it behave with the different API. e.g. chokikdar's .close would equal .end. Chokidar does not feature an event object, but returns file stats. Adapt tests and feature a new API, or move to the new API and update all the docs?

@phated
Copy link
Member Author

phated commented Sep 15, 2015

@ddprrt the watch API is going to be a tiny facade over chokidar's watch. We don't plan to have backward-compat with gulp 3.9's watch

@phated
Copy link
Member Author

phated commented Sep 30, 2015

The chokidar switch has been made (in the 4.0 branch)!!!! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants