Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on tasks depending on other async tasks #36

Merged
merged 1 commit into from Dec 4, 2013

Conversation

jackfranklin
Copy link
Contributor

I found myself getting confused when I had a task that depended on
another that was async. After a while I realised why and thought adding
a couple of sentences just to clarify for future users who may come
stuck with the same problem.

I dropped you guys a tweet earlier: https://twitter.com/Jack_Franklin/status/408017546894651392, before some help from Eric cleared things up - I'm not sure if you feel this is a problem many will come across but it had me befuddled for a few moments so I thought a quick 2 sentences in the docs might help others avoid the problem. I don't think it's immediately apparent why returning the stream works as a solution, so I hope this might clarify it.

I found myself getting confused when I had a task that depended on
another that was async. After a while I realised why and thought adding
a couple of sentences just to clarify for future users who may come
stuck with the same problem.
@yocontra
Copy link
Member

yocontra commented Dec 4, 2013

👍

@yocontra yocontra merged this pull request into gulpjs:master Dec 4, 2013
@robrich
Copy link
Contributor

robrich commented Dec 4, 2013

I think the confusion here is not in the second task's dependency list but rather in the first task's completion status. You need to pass a hint to Orchestrator so it knows how to determine when your task is complete. In absence of a hint, Orchestrator presumes your task is synchronous, and thus complete as soon as it returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants