Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make CI build faster #635

Merged
merged 1 commit into from Aug 30, 2014
Merged

make CI build faster #635

merged 1 commit into from Aug 30, 2014

Conversation

PeterDaveHello
Copy link
Contributor

No description provided.

@phated
Copy link
Member

phated commented Aug 23, 2014

Why not depth: 1?

@PeterDaveHello
Copy link
Contributor Author

If there exist error and you want to rebuild it after new commits was pushed, the old one may be invisible, it depends on the workflow, if everything will send by pull request, then no this problem, and if you can accept to ignore the error CI build, just build on newer commit, then 1 will be fine.

I can update it if you want :)

@pkozlowski-opensource
Copy link
Contributor

@PeterDaveHello as with any optimisation I always like to know what we gain. Did you measure time before / after this change? Looking at the recent PRs on travis the timing seems to be around 1min30s:
https://travis-ci.org/gulpjs/gulp/pull_requests

I'm definitively not saying that this change is bad or anything, just curious here.

@PeterDaveHello
Copy link
Contributor Author

Yeah, in fact, I think the time of cloning repo to CI server has a large deviation range. Shallow clone really help to save the time and bandwidth because drop the useless revisions, that's for sure, and the depth's default value is 50 on travis CI, I think we usually don't need so many revisions, decrease this value can help save more time then 50.

@yocontra
Copy link
Member

Why don't they do this by default? Seems like a waste of time and bandwidth to clone shit thats not being tested

@PeterDaveHello
Copy link
Contributor Author

don't know

yocontra added a commit that referenced this pull request Aug 30, 2014
@yocontra yocontra merged commit 856df83 into gulpjs:master Aug 30, 2014
@PeterDaveHello PeterDaveHello deleted the patch-1 branch August 30, 2014 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants