Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds batched output for logging #691

Closed
wants to merge 2 commits into from
Closed

adds batched output for logging #691

wants to merge 2 commits into from

Conversation

stringparser
Copy link

Recently I have been reading a lot the bin code and noticed these lines.

  • adds lib/batchThese.js
  • modifies logging for task_start and task_stop events so the output is batched.

The reason for adding a batched output for task_stop is because sometimes the non-batched output for task_stop would write to stdout before the batch of task_start. I have took a constant length of 4 for the batch instead of 5 because on my 24'' monitor, when I have the terminal window at half the line breaks sometimes.

@phated
Copy link
Member

phated commented Sep 18, 2014

Very cool!

@stringparser
Copy link
Author

Haha, nice! I only added it to master, but I can do the same for the 4.0.

@yocontra
Copy link
Member

@stringparser That would be great - I think as 4.0 gets closer we should quit pushing new features to old versions and focus on that branch.

@stringparser
Copy link
Author

@contra done.

I've made a little improvement from this PR to the 4.0 one, details there. Let me know if you want this little twitch in 3.x for the time being or else lets close this one.

@stringparser
Copy link
Author

By the way, I'm loving how 4.0 looks and feels guys, I really do :)


edit: I've made the changes here equal to those of 4.0

@yocontra
Copy link
Member

Why not split console.log batching out into a module?

@stringparser
Copy link
Author

@contra, after what you left written on #694 I totally understand your point here since I didn't consider 3rd party modules.

I left some thoughts there about how one would do the batching from my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants