-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gulp API doc with info on file base #700
Conversation
Niice! to me it's very clear. Let's see what @contra says. |
// write path: '.build/dir2/dir3/whatever.txt' | ||
``` | ||
|
||
On the other hand, when `gulp.src` is used, for instance, inside of a callback where it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt mention callbacks, TMI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I've shown callback here was because this was the real situation I had run into when gulp.src
was dealing with string paths instead of glob. I can rework the example into a contrived one and pass a string path directly instead of a callback:
gulp.src('app/css/somefile.scss')
.pipe(gulp.dest('build'));
Let me know if this is preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saying it seems like too much information and doesn't really have anything to do with the API itself
I'm thinking, shouldn't this be below just like the other options? |
@contra There are 8 commits in this PR. Shall I rebase them against master into one? |
yeah, squash them down |
Done. Please review. |
Update gulp API doc with info on file base
Expand on what file base is and how it affects the relative path calculation. Fixes #699.