Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation about incremental built #971

Merged
merged 1 commit into from Mar 22, 2015

Conversation

dinoboff
Copy link
Contributor

@@ -13,7 +13,8 @@

## Documentation

For a Getting started guide, API docs, recipes, making a plugin, etc. see the [documentation page](/docs/README.md)!
For a Getting started guide, API docs, recipes, making a plugin, etc. see the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is completely your opinion and unrelated to the PR lol

@callumacrae
Copy link
Member

I feel this PR is about three times the length it actually needs to be

@dinoboff
Copy link
Contributor Author

@callumacrae reduced the scope

@@ -73,12 +73,67 @@ gulp.task('default', gulp.series('clean', 'all'));

## Incremental Builds

We recommend these plugins:
You can filter out unchanged files between runs of a task using
`gulp.src` `since` option and `gulp.lastRun`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a possessive. I'd suggest "using the gulp.src function's since option".

@callumacrae
Copy link
Member

run vs ran in one sentence:

I ran the task. I have run the task.


Type: `Number`.

Default: the value `UNDERTAKER_TIME_RESOLUTION` environment variable, or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't make sense

@dinoboff dinoboff force-pushed the dinoboff-incremental branch 4 times, most recently from 8a1121b to 5e6f869 Compare March 21, 2015 11:15
- add `gulp.lastRun` api doc.
- usage example in `README.md`
@phated phated merged commit 1b4a09f into gulpjs:4.0 Mar 22, 2015
@@ -73,12 +73,56 @@ gulp.task('default', gulp.series('clean', 'all'));

## Incremental Builds

We recommend these plugins:
You can filter out unchanged files between runs of a task using
`gulp.src` function's `since` option and `gulp.lastRun`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The since option to gulp.src and gulp.lastRun

Seems to fit better to me

@dinoboff dinoboff deleted the dinoboff-incremental branch March 23, 2015 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants