Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore files not ending by .babel.[tj]s(x) and add upward-optional root mode for babel 7 register #58

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Ignore files not ending by .babel.[tj]s(x) and add upward-optional root mode for babel 7 register #58

merged 1 commit into from
Oct 16, 2019

Conversation

ilan-schemoul
Copy link
Contributor

Let's start this PR by a quote from a great man :

Now that I've released v1.2 with babel7 and esm support, I'd like to revisit this and get it shipped in a 2.0 (along with the solution to #54). I'm definitely considering this breaking but I'm fine bumping to 2.0

So this PR aims to do that :

@ilan-schemoul
babel must now ignore files not ending by babel.js (inspired from @cs…
358b9e5 
…potcode branch, PR #41 extending ignoring to everywhere babel register is called), @babel/register now uses upward-optional mode, version bumped to 2.0.0
@ilan-schemoul ilan-schemoul mentioned this pull request Oct 12, 2019
Closed
@ilan-schemoul ilan-schemoul changed the title babel must now ignore files not ending by babel.js (inspired from @cs… Ignore files not ending by .babel.[tj]s(x) and add upward-optional root mode for babel 7 register Oct 12, 2019
@ilan-schemoul ilan-schemoul mentioned this pull request Oct 12, 2019
Closed
@phated
Copy link
Member

phated commented Oct 16, 2019

@NitroBAY Sorry that I've been unresponsive. I've been on a lot of travel for work/life.

This looks amazing. Thank you for putting in all the work here! It looks like all the tests are passing too. 🎊 🎉

@phated phated merged commit 5e2eb6e into gulpjs:master Oct 16, 2019
phated pushed a commit that referenced this pull request Oct 16, 2019
@ilan-schemoul @phated
Breaking: Ensure babel ignores non-.babel.js/ts/jsx files & enable up…
7e2683b 
…ward-optional mode (fixes #39, #41, #54) (#58)

* babel must now ignore files not ending by babel.js (inspired from @cspotcode branch, PR #41 extending ignoring to everywhere babel register is called)
* @babel/register now uses upward-optional mode
@phated
Copy link
Member

phated commented Oct 16, 2019

Slow CI is slow. I will get this published (hopefully) sometime tomorrow. Thanks again!

@ilan-schemoul
Copy link
Contributor Author

Nice, I'm glad you like my PR.

@phated
Copy link
Member

phated commented Oct 22, 2019

Published! Thanks again 🎉

@ilan-schemoul ilan-schemoul mentioned this pull request Nov 4, 2019
Closed
HRKings pushed a commit to HRKings/interpret that referenced this pull request Jan 15, 2022
@ilan-schemoul @phated
Breaking: Ensure babel ignores non-.babel.js/ts/jsx files & enable up…
cbfedf7 
…ward-optional mode (fixes gulpjs#39, gulpjs#41, gulpjs#54) (gulpjs#58)

* babel must now ignore files not ending by babel.js (inspired from @cspotcode branch, PR gulpjs#41 extending ignoring to everywhere babel register is called)
* @babel/register now uses upward-optional mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rootMode: 'upward' for @babel/register? babel-register compiles .js files; should only handle .babel.js
2 participants
@ilan-schemoul @phated