Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add .cts to support typescript 4.7 #90

Merged
merged 5 commits into from Jun 29, 2022
Merged

Conversation

cspotcode
Copy link
Contributor

@cspotcode cspotcode commented May 19, 2022

Resolves #89

This is likely blocked by publication of the next version of ts-node which adds support for the new file extensions.

@cspotcode
Copy link
Contributor Author

I've updated this PR to use typescript 4.7 rc, which will become stable in about 4 days, and to use the newest ts-node, which supports cts.

I also removed some of the alternative transpilers from the cts file extension because they were failing. I'm not sure if this was a misconfiguration on my part, or if it was because they don't support .cts.

@phated
Copy link
Member

phated commented May 21, 2022

@cspotcode Yeah, I think we should only support this through ts-node as it seems a bit specialized. I'd prefer not to use the RC, so let's wait to land this until 4.7 is released

@phated
Copy link
Member

phated commented Jun 25, 2022

@cspotcode has 4.7 been released? I don't keep up on these things. Can you update if so?

@cspotcode
Copy link
Contributor Author

Yeah, 4.7 is out, I've updated this PR accordingly.

index.js Outdated Show resolved Hide resolved
@phated
Copy link
Member

phated commented Jun 27, 2022

Couple of comments. Let's get this cleaned up and I'll make a release!

@phated phated added this to In progress in v5 Jun 27, 2022
@phated phated changed the title add cts file extension, treated identically to ts feat: Add .cts to support typescript 4.7 Jun 29, 2022
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cspotcode! I cleaned up the non ts-node stuff

@phated phated merged commit c1ffa36 into gulpjs:master Jun 29, 2022
@cspotcode
Copy link
Contributor Author

Thanks! I've been super busy, I appreciate it

@phated phated moved this from In progress to Done in v5 Jun 29, 2022
@phated phated moved this from In progress to Done in v5 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5
  
Done
Development

Successfully merging this pull request may close these issues.

Add .cts file extension
2 participants