chore!: Normalize repository, dropping node <10.13 support #11
Conversation
README.md
Outdated
| [gitter-url]: https://gitter.im/gulpjs/gulp | ||
| [gitter-image]: https://badges.gitter.im/gulpjs/gulp.svg | ||
| <!-- prettier-ignore-start --> | ||
| [range-support]: https://github.com/phated/sver-compat#range-support |
There was a problem hiding this comment.
This needs to be updated to the official sver module. The documentation about "sver-compat" need to be updated to reference the "sver" project.
package.json
Outdated
| "test": "mocha --async-only", | ||
| "cover": "istanbul cover _mocha --report lcovonly", | ||
| "coveralls": "npm run cover && istanbul-coveralls" | ||
| "test": "nyc mocha --async-only" | ||
| }, | ||
| "dependencies": { | ||
| "sver-compat": "^1.5.0" |
There was a problem hiding this comment.
This needs to use sver instead of my fork.
Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>
|
@phated I've modified what you pointed out. I replaced |
|
Thank you for identifying that change and telling me. I've thought a lot about this and tested some things locally and I feel that our tests were testing our desired behavior—that a prerelease version is not covered by the final release, since there could be breaking changes. However, there were bugs in sver-compat that weren't handling this correctly which I found while writing some tests against it. For example, |
This PR updates this project: