-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proliferation of global variables. #2
Comments
Thoughts on using a weakmap for this? |
Nevermind, it's just a string reference. |
Thoughts on 834e409 ? Does it solve this? |
Looks great, solves all my concerns. |
phated
added a commit
that referenced
this issue
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By adding each name space to global as it's own variable they all become available in every module by that name. Pretty unexpected behavior, and can return unexpected objects from the global name space.
Better to put them all on a single global object with a hard to mistakenly interact with name space. Something like:
The text was updated successfully, but these errors were encountered: