Adds a 'did you mean?' note when failing to find a task #94
Conversation
package.json
Outdated
| @@ -34,7 +34,8 @@ | |||
| "last-run": "^1.1.0", | |||
| "object.defaults": "^1.0.0", | |||
| "object.reduce": "^1.0.0", | |||
| "undertaker-registry": "^1.0.0" | |||
| "undertaker-registry": "^1.0.0", | |||
| "fast-levenshtein": "^3.0.0" | |||
There was a problem hiding this comment.
Yep, a new dep!
I originally added this as a function to the file, but spotted that this was in the dependency tree twice and figured that it was OK to use then. Open to changing it for sure.
|
This is super cool! However, the new dependency breaks our compatibility matrix (which we are updating for our next major): https://travis-ci.org/github/gulpjs/undertaker/builds/713364594 I'm also wondering if this should be done inside the default registry and implemented as a warning log so people can ignore them. |
|
Thumbs up on this - I love improving the DX and think the more of this we do the better! |
|
I'm happy with moving it to the registry, in either case I updated this PR to the same major version which I found in the dep tree and used TS' algo. The string-length dependent system there fits for me. |
…ep tree, and copy TypeScript's rules for min distance
|
Sorry for the delay here. It's been so long since anything was touched in undertaker that the CI needed some updates. I'm making those now and will test this in a branch. |
|
Alright, tested this successfully on Travis. I think we need to rethink the assertions in this library and possibly switch everything over to gulplog, but that's in a breaking change, so I think this is a solid "new feature" release. Thank you for the awesome work here! |
|
Published as 1.3.0 Thanks again! 🎉 |
|
Welcome! Thanks for updating CI |
I hit this enough times with a 'close but not quite' that I figured it was worth telling me what it actually was.