Add doc for registry #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Custom registries are constructor allowing you to pre-define/share tasks | ||
| or add custom functionality to your registries. | ||
|
|
||
| A registries prototype should define: |
|
This is amazing!!!!!! Just a couple of nits. Thank you so so so so so much for putting the time to write this up. |
dinoboff
force-pushed
the
dinoboff-registry-doc
branch
2 times, most recently
from
523aa59
to
d3a4b82
Compare
dinoboff
force-pushed
the
dinoboff-registry-doc
branch
from
d3a4b82
to
3f67a70
Compare
|
@phated You're welcome. Thanks for all your work. |
|
❤️ I was dreading writing these. Thanks again |
| console.log('Server bind to ' + this.bindTo); | ||
| console.log('Serving' + this.build); | ||
| cb(); | ||
| })) |
There was a problem hiding this comment.
@phated is that example works? I am not sure how the tasks get run. It seems Undertaker.prototype.get returns the original function, not the wrapped one.
[...]
taker.task('default', function(cb) {
console.log('Server bind to ' + this.bindTo);
console.log('Serving' + this.build);
cb();
});
var noop = function(){};
tasker.get('default')(noop);
// Server bind to undefined
// Serving undefined
tasker._registry.get('default')(noop);
// Server bind to 0.0.0.0:8888
// Serving './build'There was a problem hiding this comment.
nerver mind
tasker.parallel(['default])(noop);
// Server bind to 0.0.0.0:8888
// Serving ./build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10