-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to cache using a temp file if home is unwriteable #30
Conversation
Thanks @ilikebits! Can you add a passing test for this that fails without this addition? |
@tkellen isn't this similar to the patch that caused all the havoc not too long ago? |
@phated, that patch (#21) attempted to create new cache directories; this one fixes current cache behaviour to be as described. When @tkellen, working on tests now. There seem to be a couple of bugs with existing tests e.g. files written to temporary directories are not correctly cleaned up after each test because any invalid path passed to |
@tkellen Tests finished. I simulate an unwriteable |
Thanks @ilikebits! This looks good to me. Can you please squash your commits? Also, if I give you commit and npm publish access for this repo, would you be willing to triage any issues that result? |
Sure thing; this bug blocks me from deploying on my PaaS provider, and I'd be happy to help out others with the same issue. I'm @ilikebits on npm as well. |
Attempt to cache using a temp file if home is unwriteable
Sounds good @ilikebits! Matster is all set to |
Hey @ilikebits! Are you going to publish this? |
Sorry for the delay; it's finals crunch time right now, planning to release this weekend post-finals so I can address any bugs that come up. |
Attempt to cache using a temp file if home is unwriteable
This helps alleviate #22 and #19, by attempting to use a temporary file to cache if the home directory is unwriteable. Previously, a temporary file was only used if the home directory could not be found.