Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude example flags provided by node #66

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Sep 2, 2023

This PR is to fix the issue #65.

In recent Node.js, the output of node --v8-options contains extra lines in the --xxx format, like:

% node --v8-options
SSE3=1 SSSE3=1 SSE4_1=1 SSE4_2=1 SAHF=1 AVX=1 AVX2=1 FMA3=1 BMI1=1 BMI2=1 LZCNT=1 POPCNT=1 ATOM=0
The following syntax for options is accepted (both '-' and '--' are ok):
  --flag        (bool flags only)
  --no-flag     (bool flags only)
  --flag=value  (non-bool flags only, no spaces around '=')
  --flag value  (non-bool flags only)
  --            (captures all remaining args in JavaScript)

Options:
  --abort-on-contradictory-flags (Disallow flags or implications overriding each other.)
        type: bool  default: --noabort-on-contradictory-flags
  ...

Regarding this issue, we had implemented a solution to extract options from Options: onward, but there was a mistake in that. This PR is to correct that mistake.

Closes #65

@sttk sttk requested a review from phated September 2, 2023 06:30
@phated
Copy link
Member

phated commented Sep 3, 2023

This needs a test. I'll look into adding it.

@phated phated changed the title fix: exclude invalid flags fix: Exclude example flags provided by node Sep 3, 2023
@phated phated merged commit 58f009a into gulpjs:master Sep 3, 2023
15 checks passed
@sttk sttk deleted the fix-issue65 branch September 3, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result includes --flag, which is not a valid flag
3 participants