empty arrays = dead stream, closes #40

gulpjs · Oct 9, 2014 · 6bba193 · 6bba193
1 parent 3e3d371
commit 6bba193
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/lib/src/index.js b/lib/src/index.js
@@ -53,6 +53,12 @@ function isValidGlob(glob) {
   if (typeof glob === 'string') {
     return true;
   }
+  if (Array.isArray(glob) && glob.length !== 0) {
+    return glob.every(isValidGlob);
+  }
+  if (Array.isArray(glob) && glob.length === 0) {
+    return true;
+  }
   return false;
 }
 

diff --git a/test/src.js b/test/src.js
@@ -26,7 +26,7 @@ describe('source stream', function() {
   it('should explode on invalid glob (empty)', function(done) {
     var stream;
     try {
-      stream = gulp.src();
+      stream = vfs.src();
     } catch (err) {
       should.exist(err);
       should.not.exist(stream);
@@ -37,23 +37,20 @@ describe('source stream', function() {
   it('should explode on invalid glob (number)', function(done) {
     var stream;
     try {
-      stream = gulp.src(123);
+      stream = vfs.src(123);
     } catch (err) {
       should.exist(err);
       should.not.exist(stream);
       done();
     }
   });
 
-  it('should explode on invalid glob (empty array)', function(done) {
-    var stream;
-    try {
-      stream = gulp.src([]);
-    } catch (err) {
-      should.exist(err);
-      should.not.exist(stream);
+  it('should not explode on invalid glob (empty array)', function(done) {
+    var stream = vfs.src([]);
+    stream.once('data', done);
+    stream.once('end', function(){
       done();
-    }
+    });
   });
 
   it('should pass through writes', function(done) {