cleanup node-engine-versions -> fix tests #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaimi
force-pushed
the
node-engine-versions
branch
from
284c6e7
to
c6fbcf3
Compare
i.e. drop versions which are EOL and add newer and future ones
Blaimi
force-pushed
the
node-engine-versions
branch
from
c6fbcf3
to
710cae4
Compare
|
We have a specific support matrix. |
|
ok, I respect that. But obviously the tests are failing for the older versions so IMHO your support marix mentions versions which are not supported in practice — or the tests need an update. But mentioning a support matrix to excuse failing tests is not exactly state of the art. If you can give me some hints on why the tests are failing I can have a look at them and maybe fix the tests according to the support matrix. As it seems to me by now (without deep investigation) the problem seem to be that one of the libraries dropped support for tge 0.* versions of nodjs. Can you confirm this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. drop versions which are EOL and add newer and future ones