Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone stream #33

Merged
merged 4 commits into from
Aug 29, 2014
Merged

Clone stream #33

merged 4 commits into from
Aug 29, 2014

Conversation

popomore
Copy link
Contributor

send an available PR for #9

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b5a62f0 on popomore:clone-stream into 76165e0 on wearefractal:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d37b57b on popomore:clone-stream into 76165e0 on wearefractal:master.

@@ -93,10 +102,10 @@ File.prototype.pipe = function(stream, opt) {
}
return stream;
}
if (this.isNull()) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need condition, causing throw error when set contents of other type

yocontra added a commit that referenced this pull request Aug 29, 2014
@yocontra yocontra merged commit 3dedd52 into gulpjs:master Aug 29, 2014
@popomore popomore deleted the clone-stream branch August 29, 2014 06:54
@popomore
Copy link
Contributor Author

Can you publish a new version?

@yocontra
Copy link
Member

Publishing as 0.4.0

@popomore
Copy link
Contributor Author

Good 👯

@yocontra
Copy link
Member

New vinyl-fs was bumped as well - thanks for the PRs!

phated pushed a commit that referenced this pull request Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants