Add dirname, basename and extname getters #46
Conversation
| @@ -158,6 +158,36 @@ Object.defineProperty(File.prototype, 'relative', { | |||
| } | |||
| }); | |||
|
|
|||
| Object.defineProperty(File.prototype, 'dirname', { | |||
There was a problem hiding this comment.
file.base already exists, using dirname for output would be an antipattern
There was a problem hiding this comment.
dirname has a different meaning and can actually be different than file.base. For example:
gulp.src('assets/css/**/*.scss')Every file's file.base will be assets/css but any file in a subdirectory will have a different dirname.
|
👍 This would be very handy. I would especially like being able to do `file.extension = '.foo' to change the extension, instead of having to use the gutil helper. So everything should have setters too IMHO. |
|
@phated thoughts? |
| return path.extname(this.path); | ||
| }, | ||
| set: function() { | ||
| throw new Error('File.extname is generated from the base and path attributes. Do not modify it.'); |
There was a problem hiding this comment.
i do agree that if we have a setter for this it should use the replace-ext module on path
|
Right on, I've added setters for all of these properties. What do you guys think? |
| return path.extname(this.path); | ||
| }, | ||
| set: function(extname) { | ||
| this.path = replaceExt(this.path, extname); |
There was a problem hiding this comment.
setters should also throw the errors on no path, or just do nothing
There was a problem hiding this comment.
I agree and personally prefer that they throw. Added.
jeremyruppel
force-pushed
the
pathname-helpers
branch
from
f869ff6
to
5a41647
Compare
|
@jeremyruppel Can you also update the docs? |
jeremyruppel
force-pushed
the
pathname-helpers
branch
from
b5f71cb
to
d8f8497
Compare
|
Just squashed these commits. @contra @sindresorhus @phated thoughts? |
|
@jeremyruppel Rebase? |
jeremyruppel
force-pushed
the
pathname-helpers
branch
from
d8f8497
to
e09817f
Compare
|
@contra yep! README conflicts. Sorry about the trailing whitespace stuff. |
Add dirname, basename and extname getters
|
Thanks @jeremyruppel ! |
|
Thanks @contra & @sindresorhus! |
| @@ -38,42 +38,42 @@ var coffeeFile = new File({ | |||
|
|
|||
| #### options.cwd | |||
|
|
|||
| Type: `String` | |||
Add dirname, basename and extname getters
Not sure if you guys would consider this bloat or a useful feature, but I often find myself wanting these pathname-style helpers when working with vinyl Files. Cheers!