Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone with constructor #91

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Clone with constructor #91

merged 1 commit into from
Jun 7, 2016

Conversation

darsain
Copy link
Contributor

@darsain darsain commented Jun 7, 2016

Changes #clone() to return new this.constructor() instead of new File() so it works properly even on objects extended from Vinyl.

@phated
Copy link
Member

phated commented Jun 7, 2016

This is super cool. I wonder if it breaks functionality that people were relying on.

@darsain
Copy link
Contributor Author

darsain commented Jun 7, 2016

It only affects classes that extend from Vinyl. I don't think that anyone would expect their ExtendedVinyl#clone() to return Vinyl object.

@phated phated merged commit 7fc1aca into gulpjs:master Jun 7, 2016
@darsain darsain deleted the clone-with-constructor branch August 6, 2016 13:43
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
ee96ffc
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
632931b
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
33fdd7d
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
8eccaa3
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
3ee62ca
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
ff75f53
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
c0f6c4a
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
63208c4
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
c3860aa
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
5dbe19c
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
a9b77d3
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
743ba4e
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
c22f887
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
72c7303
phated pushed a commit that referenced this pull request Sep 27, 2016
@darsain @phated
Fix: Clone with constructor (#91)
94c4e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darsain @phated