Update index.js #94
Closed
Update index.js #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,7 +141,7 @@ File.prototype.inspect = function() { | |||
| }; | |||
|
|
|||
| File.isVinyl = function(file) { | |||
| return (file && file._isVinyl === true) || false; | |||
| return Boolean(file && file._isVinyl); | |||
There was a problem hiding this comment.
do we even need this? file && file._isVinyl should be enough right
There was a problem hiding this comment.
In old versions of vinyl, that property doesn't exist. We should be casting with !! though.
There was a problem hiding this comment.
This check was actually changed rather recently and I don't see a reason to change it. Also, if someone set their own _isVinyl = 'foo' the above change would report true when it should report false.
|
These changes are overly pedantic so I'm going to close this. However, they made me notice an issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.