Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPAID loading is inconsistent #60

Closed
edrpls opened this issue Dec 19, 2019 · 2 comments
Closed

VPAID loading is inconsistent #60

edrpls opened this issue Dec 19, 2019 · 2 comments

Comments

@edrpls
Copy link

edrpls commented Dec 19, 2019 •
edited

VPAID loading is inconsistent and depending on the browser, more likely to fail, this could be due to a race condition between the moment startAd is called and the VPAID is loaded
@edrpls edrpls changed the title VPAID loading is inconsisteng VPAID loading is inconsistent Dec 19, 2019
edrpls pushed a commit that referenced this issue Dec 20, 2019
Bugfix/inconsistent VAST loading (#64)
69ee668 
* Change script validation to always use the last URL

* Improve demo page

* include and replace VAST [timestamp] macro (#60)
@edrpls edrpls mentioned this issue Dec 20, 2019
Merged
@edrpls edrpls closed this as completed Dec 20, 2019
@edrpls
Copy link
Author

edrpls commented Dec 23, 2019 •
edited

Seems like there are no issues rendering when the tag is already visible, but rendering video from a lightbox has some issues still. I think this could be because the thumbnail might already be visible, while the lightbox is not, but it still might be sending the ready event.

@edrpls edrpls reopened this Dec 23, 2019
edrpls pushed a commit that referenced this issue Dec 24, 2019
Prevent VAST load until container is visible (#60)
53f7861
This was referenced Dec 24, 2019
Open
Merged
edrpls pushed a commit that referenced this issue Dec 24, 2019
Prevent VAST load until container is visible (#60) (#67)
0133330
@edrpls edrpls closed this as completed Dec 24, 2019
@edrpls edrpls mentioned this issue Dec 24, 2019
Closed
@edrpls
Copy link
Author

edrpls commented Dec 28, 2019

Some VAST with VPAID still refuse to work, it seems this happens because the container is not ready and visible by the time we try to play it, this issue happens when rendering the player inside modals, especially inside iframes.

@edrpls edrpls reopened this Dec 28, 2019
This was referenced Jan 8, 2020
Open
Merged
@edrpls edrpls closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edrpls