Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Removed mandatory bio #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed mandatory bio #23

wants to merge 1 commit into from

Conversation

memxor
Copy link

@memxor memxor commented Jul 10, 2023

Removed mandatory bio requirement from line 185 in packages > gpl-core > src > profile.ts

@abishekk92 abishekk92 requested a review from vjgpt July 10, 2023 12:22
vjgpt
vjgpt suggested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@vjgpt vjgpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@memxor please update the ProfileMetadataType from a type to an interface with 'bio & avatar' as optional fields, and adjust the field checks in the validateProfileMetadata function to handle these optional fields

@memxor
Copy link
Author

memxor commented Jul 11, 2023

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjgpt vjgpt vjgpt requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memxor @vjgpt