feat: support for darwin arm64

gunar · Feb 2, 2023 · 95286fc · 95286fc
1 parent a7a2b1e
commit 95286fc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v2.1.0](https://github.com/gunar/shellcheck/releases/tag/v2.1.0) - 2023-02-02
+
+### Added
+
+- `darwin` (`arm64`) support via [Rosetta 2](https://support.apple.com/HT211861)
+
 ## [v2.0.0](https://github.com/gunar/shellcheck/releases/tag/v2.0.0) - 2023-01-31
 
 ### Added

diff --git a/README.md b/README.md
@@ -9,6 +9,8 @@ Downloads the most recent version of [koalaman](https://github.com/koalaman)'s [
 
 ## Installation
 
+> **Warning**: Node.js version `>= 18.4.0 || >= 16.17.0` is required
+
 ```sh
 npm install --save-dev shellcheck
 ```
@@ -60,11 +62,12 @@ await download({
 
 > **Note**: [`Platform`](https://nodejs.org/api/process.html#processplatform) and [`Architecture`](https://nodejs.org/api/process.html#processarch) follow _Node.js_ naming convention
 
-| **Platform** | **Architecture** |
-| ------------ | ---------------- |
+| **Platform** | **Architecture** | **Notes**                                                                                                                                                                                                                                                                                                       |
+| ------------ | ---------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `linux`      | `arm64`          |
 | `linux`      | `x64`            |
 | `darwin`     | `x64`            |
+| `darwin`     | `arm64`          | [Rosetta 2](https://support.apple.com/HT211861) must be installed. There is no native binary for `darwin arm64` at the moment (see [this](https://github.com/koalaman/shellcheck/issues/2109)). As a result, the downloaded binary is for `x64`, and `Rosetta 2` translates it to operate with `Apple Silicon`. |
 | `win32`      | `x64`            |
 
 ## Contributing

diff --git a/src/configs/config.ts b/src/configs/config.ts
@@ -97,7 +97,10 @@ export const config: Config = {
     },
     darwin: {
       platform: 'darwin',
-      architectures: [['x64', 'x86_64']],
+      architectures: [
+        ['x64', 'x86_64'],
+        ['arm64', 'x86_64']
+      ],
       archive: 'tar.xz'
     },
     win32: { platform: '', architectures: [['x64', '']], archive: 'zip' }

diff --git a/tests/helpers/index.ts b/tests/helpers/index.ts
@@ -21,7 +21,7 @@ export const ARCHITECTURES_SUPPORTED: Record<
   aix: [],
   android: [],
   cygwin: [],
-  darwin: ['x64'],
+  darwin: ['x64', 'arm64'],
   freebsd: [],
   haiku: [],
   linux: ['arm64', 'x64'],