test(directive): Improve test coverage

gund · Feb 18, 2017 · 16ff8f1 · 16ff8f1
1 parent 435e3dd
commit 16ff8f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/dynamic/dynamic.directive.ts b/src/dynamic/dynamic.directive.ts
@@ -102,14 +102,12 @@ export class DynamicDirective implements OnChanges, DoCheck, OnDestroy {
         .subscribe(this.ndcDynamicOutputs[p]));
   }
 
-  notifyOnInputChanges(changes: SimpleChanges, forceFirstChanges: boolean) {
+  notifyOnInputChanges(changes: SimpleChanges = {}, forceFirstChanges: boolean) {
     if (forceFirstChanges) {
       changes = this._collectFirstChanges();
     }
 
-    if (changes && this._componentInst) {
-      this._componentInst.ngOnChanges(changes);
-    }
+    this._componentInst.ngOnChanges(changes);
   }
 
   private _collectFirstChanges(): SimpleChanges {

diff --git a/src/test/component-injector.component.ts b/src/test/component-injector.component.ts
@@ -1,5 +1,5 @@
 import { ComponentInjector } from '../dynamic';
-import { Component, ComponentRef, EventEmitter } from '@angular/core';
+import { Component, ComponentRef, EventEmitter, Input } from '@angular/core';
 
 @Component({
   selector: 'component-injector',