Skip to content

Commit

Permalink
feat(lib): use new ComponentRef API to set inputs on components
Browse files Browse the repository at this point in the history
This allowed to remove code for generating and calling OnChanges hook manually as it's not handled
by Angular directly. As this  part is no longer in the lib dynamic directives no longer receive
OnChanges hook calls.
  • Loading branch information
gund committed Aug 27, 2022
1 parent 64d82cc commit 7cc48a6
Show file tree
Hide file tree
Showing 8 changed files with 971 additions and 1,044 deletions.
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,13 @@ class MyComponent {

**Since v3.1.0** you can now declaratively set directives, via `ndcDynamicDirectives`.

**NOTE**: In dynamic directives queries like `@ContentChild` and host decorators like `@HostBinding`
will not work due to involved complexity required to handle it (but PRs are welcome!).
> **NOTE**:
> There is a known issue with OnChanges hook not beign triggered on dynamic directives
> since this part of functionality has been removed from the core as Angular now
> supports this out of the box for dynamic components.
>
> In dynamic directives queries like `@ContentChild` and host decorators like `@HostBinding`
> will not work due to involved complexity required to implement it (but PRs are welcome!).
Import module `DynamicDirectivesModule` and then in template:

Expand Down
Loading

0 comments on commit 7cc48a6

Please sign in to comment.