Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs don't map to correct property when bindingPropertyName is used. #102

Closed
shelbyd opened this issue Mar 8, 2018 · 2 comments
Closed
Labels

Comments

@shelbyd
Copy link

shelbyd commented Mar 8, 2018

Given

class Parent {
  inputs = {
    foo: 'foo',
  };
}

@Component()
class Child {
  @Input('foo') bar: string;
}

Expected

Child component has property bar set to 'foo'.

Actual

Child component has property foo set to 'foo'.

@gund
Copy link
Owner

gund commented Mar 8, 2018

Hi, thanks for reporting this.

Yes, this use-case actually was never supported, and nobody even used it thus far =)

I have an idea how it can be fixed (using information about component's IO from it's ComponentFactory) but for right now do not have access to laptop so won't be able to implement a fix.

If you want to submit a PR with the fix please feel free to do so.
And if you have any questions let me know.

@gund gund added the bug label Mar 19, 2018
gund added a commit that referenced this issue Mar 23, 2018
Also fix a bug when inputs/outputs where comletely reassigned and changes were not picked up

#102
@gund gund closed this as completed in 7008156 Mar 23, 2018
@gund
Copy link
Owner

gund commented Mar 23, 2018

Fix released in v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants